feat: require standalone admin login before the web workbench
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
"""Administrator sessions and browser boundary checks, entirely offline."""
|
||||
|
||||
import asyncio
|
||||
from http.cookies import SimpleCookie
|
||||
from pathlib import Path
|
||||
import tempfile
|
||||
import threading
|
||||
@@ -21,21 +22,190 @@ class AuthTests(unittest.TestCase):
|
||||
self.addCleanup(self.temporary.cleanup)
|
||||
self.root = Path(self.temporary.name)
|
||||
self.manager, self.updates = FakeManager(), FakeUpdates()
|
||||
self.assets = self.root / "static"
|
||||
self.assets.mkdir()
|
||||
for name, content in {
|
||||
"index.html": '<html><nav>WORKBENCH_ONLY</nav><script src="/static/app.js"></script></html>',
|
||||
"login.html": '<html><form>ADMIN_LOGIN_ONLY</form><script src="/static/login.js"></script></html>',
|
||||
"login.js": "// LOGIN_SCRIPT_ONLY",
|
||||
"login.css": "/* LOGIN_STYLE_ONLY */",
|
||||
"styles.css": "/* SHARED_STYLE_ONLY */",
|
||||
"dom.js": "// SHARED_DOM_ONLY",
|
||||
**{name: "// WORKBENCH_ONLY" for name in ("app.js", "api.js", "pages.js", "ui.js", "table.js", "forms.js", "future.mjs")},
|
||||
}.items():
|
||||
(self.assets / name).write_text(content, encoding="utf-8")
|
||||
self.enterContext(patch("requests.sessions.Session.request", side_effect=AssertionError("No real network access")))
|
||||
|
||||
def client(self, settings=None, **kwargs):
|
||||
settings = settings or WebConfig(data_dir=self.root)
|
||||
app = create_app(manager=self.manager, updates=self.updates, config=settings)
|
||||
with patch("ranch_web.app.__file__", str(self.root / "app.py")):
|
||||
app = create_app(manager=self.manager, updates=self.updates, config=settings)
|
||||
return self.enterContext(TestClient(app, base_url="http://localhost", client=("127.0.0.1", 50000), **kwargs))
|
||||
|
||||
def cookie_headers(self, response):
|
||||
cookies = []
|
||||
for header in response.headers.get_list("set-cookie"):
|
||||
parsed = SimpleCookie()
|
||||
parsed.load(header)
|
||||
cookies.append(parsed[COOKIE_NAME])
|
||||
return cookies
|
||||
|
||||
def test_unauthenticated_workbench_and_scripts_redirect_before_file_access(self):
|
||||
client = self.client(WebConfig(data_dir=self.root, password="correct"))
|
||||
with patch("ranch_web.app.FileResponse", side_effect=AssertionError("Workbench HTML must stay unopened")), \
|
||||
patch("ranch_web.app._Assets.lookup_path", side_effect=AssertionError("Workbench assets must stay unopened")):
|
||||
for path in ("/", "/?next=/api/accounts", "/static/index.html", "/static/app.js", "/static/api.js",
|
||||
"/static/pages.js", "/static/ui.js", "/static/table.js", "/static/forms.js", "/static/future.mjs",
|
||||
"/static//index.html", "/static/%69ndex.html", "/static/login.js/../app.js"):
|
||||
with self.subTest(path=path):
|
||||
response = client.get(path, follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 303)
|
||||
self.assertEqual(response.headers["location"], "/login")
|
||||
self.assertEqual(response.headers["cache-control"], "no-store")
|
||||
self.assertNotIn("WORKBENCH_ONLY", response.text)
|
||||
self.assertEqual(response.headers["x-content-type-options"], "nosniff")
|
||||
self.assertEqual(self.manager.calls, [])
|
||||
self.assertEqual(self.updates.calls, [])
|
||||
|
||||
def test_login_page_and_shared_assets_are_public_without_workbench(self):
|
||||
client = self.client(WebConfig(data_dir=self.root, password="correct"))
|
||||
for path in ("/login", "/static/login.html"):
|
||||
with self.subTest(path=path):
|
||||
response = client.get(path)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertIn("text/html", response.headers["content-type"])
|
||||
self.assertIn("ADMIN_LOGIN_ONLY", response.text)
|
||||
self.assertNotIn("WORKBENCH_ONLY", response.text)
|
||||
self.assertEqual(response.headers["cache-control"], "no-store")
|
||||
for name in ("login.js", "login.css", "styles.css", "dom.js"):
|
||||
with self.subTest(name=name):
|
||||
response = client.get("/static/" + name)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertNotIn("WORKBENCH_ONLY", response.text)
|
||||
self.assertEqual(self.manager.calls, [])
|
||||
self.assertEqual(self.updates.calls, [])
|
||||
|
||||
def test_authenticated_login_redirects_home_and_workbench_assets_are_private(self):
|
||||
client = self.client(WebConfig(data_dir=self.root, password="correct"))
|
||||
self.assertEqual(client.post("/api/auth/login", json={"password": "correct"}).status_code, 200)
|
||||
for path in ("/login", "/static/login.html"):
|
||||
with self.subTest(path=path):
|
||||
response = client.get(path, follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 303)
|
||||
self.assertEqual(response.headers["location"], "/")
|
||||
self.assertEqual(response.headers["cache-control"], "no-store")
|
||||
for path in ("/", "/static/index.html", "/static/app.js", "/static/api.js", "/static/pages.js", "/static/future.mjs"):
|
||||
with self.subTest(path=path):
|
||||
response = client.get(path)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertIn("WORKBENCH_ONLY", response.text)
|
||||
self.assertEqual(response.headers["cache-control"], "no-store")
|
||||
self.assertEqual(self.manager.calls, [])
|
||||
self.assertEqual(self.updates.calls, [])
|
||||
|
||||
def test_ui_gate_preserves_public_api_and_json_unauthorized_responses(self):
|
||||
client = self.client(WebConfig(data_dir=self.root, password="correct"))
|
||||
for path in ("/api/health", "/api/meta", "/api/auth/status"):
|
||||
with self.subTest(path=path):
|
||||
self.assertEqual(client.get(path).status_code, 200)
|
||||
for method, path in (("GET", "/api/accounts"), ("GET", "/api/schema"), ("POST", "/api/accounts")):
|
||||
with self.subTest(method=method, path=path):
|
||||
response = client.request(method, path, follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 401)
|
||||
self.assertNotIn("location", response.headers)
|
||||
self.assertEqual(response.json()["error"]["code"], "authentication_required")
|
||||
self.assertEqual(client.post("/api/auth/logout").status_code, 200)
|
||||
self.assertEqual(self.manager.calls, [])
|
||||
|
||||
def test_invalid_and_expired_sessions_cannot_open_workbench(self):
|
||||
settings = WebConfig(data_dir=self.root, password="correct", session_ttl=60)
|
||||
client = self.client(settings)
|
||||
for token in ("invalid", "A" * 43):
|
||||
with self.subTest(token=token):
|
||||
response = client.get("/", headers={"Cookie": f"{COOKIE_NAME}={token}"}, follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 303)
|
||||
self.assertEqual(response.headers["location"], "/login")
|
||||
with patch("ranch_web.app.time.monotonic", return_value=0):
|
||||
self.assertEqual(client.post("/api/auth/login", json={"password": "correct"}).status_code, 200)
|
||||
for path in ("/", "/static/index.html", "/static/app.js"):
|
||||
with self.subTest(path=path):
|
||||
response = client.get(path, follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 303)
|
||||
self.assertEqual(response.headers["location"], "/login")
|
||||
self.assertEqual(client.get("/api/accounts").status_code, 401)
|
||||
self.assertIn("ADMIN_LOGIN_ONLY", client.get("/login").text)
|
||||
|
||||
def test_missing_login_asset_returns_unavailable_without_workbench_fallback(self):
|
||||
client = self.client(WebConfig(data_dir=self.root, password="correct"))
|
||||
(self.assets / "login.html").unlink()
|
||||
response = client.get("/login")
|
||||
self.assertEqual(response.status_code, 503)
|
||||
self.assertNotIn("WORKBENCH_ONLY", response.text)
|
||||
response = client.get("/", follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 303)
|
||||
self.assertEqual(response.headers["location"], "/login")
|
||||
|
||||
def test_login_migrates_legacy_api_cookie_and_revokes_previous_session(self):
|
||||
client = self.client(WebConfig(data_dir=self.root, password="correct"))
|
||||
client.post("/api/auth/login", json={"password": "correct"})
|
||||
token = client.cookies.get(COOKIE_NAME)
|
||||
domain = next(iter(client.cookies.jar)).domain
|
||||
client.cookies.clear()
|
||||
client.cookies.set(COOKIE_NAME, token, domain=domain, path="/api")
|
||||
self.assertEqual(client.get("/", follow_redirects=False).status_code, 303)
|
||||
response = client.post("/api/auth/login", json={"password": "correct"})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
cookies = {cookie["path"]: cookie for cookie in self.cookie_headers(response)}
|
||||
self.assertEqual(set(cookies), {"/", "/api"})
|
||||
self.assertEqual(cookies["/api"]["max-age"], "0")
|
||||
self.assertEqual(cookies["/api"].value, "")
|
||||
self.assertNotEqual(cookies["/"].value, token)
|
||||
self.assertEqual([(cookie.name, cookie.path) for cookie in client.cookies.jar], [(COOKIE_NAME, "/")])
|
||||
self.assertEqual(client.get("/").status_code, 200)
|
||||
self.assertEqual(client.get("/api/accounts").status_code, 200)
|
||||
self.assertEqual(client.get("/api/accounts", headers={"Cookie": f"{COOKIE_NAME}={token}"}).status_code, 401)
|
||||
|
||||
def test_logout_clears_root_and_legacy_cookies_and_blocks_ui_replay(self):
|
||||
client = self.client(WebConfig(data_dir=self.root, password="correct"))
|
||||
client.post("/api/auth/login", json={"password": "correct"})
|
||||
token = client.cookies.get(COOKIE_NAME)
|
||||
domain = next(iter(client.cookies.jar)).domain
|
||||
client.cookies.set(COOKIE_NAME, "stale-legacy-cookie", domain=domain, path="/api")
|
||||
response = client.post("/api/auth/logout")
|
||||
self.assertEqual(response.status_code, 200)
|
||||
cookies = {cookie["path"]: cookie for cookie in self.cookie_headers(response)}
|
||||
self.assertEqual(set(cookies), {"/", "/api"})
|
||||
for cookie in cookies.values():
|
||||
self.assertEqual(cookie.value, "")
|
||||
self.assertEqual(cookie["max-age"], "0")
|
||||
self.assertTrue(cookie["httponly"])
|
||||
self.assertEqual(cookie["samesite"], "strict")
|
||||
self.assertEqual(list(client.cookies.jar), [])
|
||||
for path in ("/", "/static/index.html", "/static/app.js"):
|
||||
with self.subTest(path=path):
|
||||
self.assertEqual(client.get(path, follow_redirects=False).status_code, 303)
|
||||
response = client.get(path, headers={"Cookie": f"{COOKIE_NAME}={token}"}, follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 303)
|
||||
self.assertEqual(response.headers["location"], "/login")
|
||||
self.assertFalse(client.get("/api/auth/status").json()["authenticated"])
|
||||
self.assertEqual(client.get("/api/accounts", headers={"Cookie": f"{COOKIE_NAME}={token}"}).status_code, 401)
|
||||
|
||||
def test_loopback_bypass_is_local_and_has_no_password_cookie(self):
|
||||
client = self.client()
|
||||
self.assertEqual(client.get("/api/auth/status").json(), {"required": False, "authenticated": True, "access_mode": "local"})
|
||||
response = client.post("/api/accounts", json={"demo": True}, headers={"Origin": "http://localhost"})
|
||||
self.assertEqual(response.status_code, 201)
|
||||
self.assertNotIn("set-cookie", response.headers)
|
||||
self.assertIn("WORKBENCH_ONLY", client.get("/").text)
|
||||
self.assertEqual(client.get("/login", follow_redirects=False).headers["location"], "/")
|
||||
remote = self.enterContext(TestClient(create_app(manager=self.manager, updates=self.updates, config=WebConfig(data_dir=self.root)), base_url="http://localhost", client=("192.0.2.1", 50001)))
|
||||
self.assertEqual(remote.get("/api/accounts").status_code, 403)
|
||||
self.assertFalse(remote.get("/api/auth/status").json()["authenticated"])
|
||||
for path in ("/", "/static/index.html", "/static/app.js"):
|
||||
with self.subTest(path=path):
|
||||
response = remote.get(path, follow_redirects=False)
|
||||
self.assertEqual(response.status_code, 303)
|
||||
self.assertEqual(response.headers["location"], "/login")
|
||||
|
||||
def test_remote_bind_and_public_proxy_names_require_password(self):
|
||||
for values in ({"host": "0.0.0.0"}, {"host": "::"}, {"host": "192.0.2.10"}, {"allowed_hosts": ("ranch.example",)}, {"allowed_origins": ("https://ranch.example",)}):
|
||||
@@ -50,10 +220,15 @@ class AuthTests(unittest.TestCase):
|
||||
response = client.post("/api/auth/login", json={"password": "离线管理密码"})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertNotIn("离线管理密码", response.text)
|
||||
cookie = response.headers["set-cookie"].lower()
|
||||
self.assertIn("httponly", cookie)
|
||||
self.assertIn("samesite=strict", cookie)
|
||||
self.assertIn("path=/api", cookie)
|
||||
cookies = {cookie["path"]: cookie for cookie in self.cookie_headers(response)}
|
||||
cookie = cookies["/"]
|
||||
self.assertTrue(cookie["httponly"])
|
||||
self.assertEqual(cookie["samesite"], "strict")
|
||||
self.assertEqual(cookie["max-age"], str(client.app.state.config.session_ttl))
|
||||
self.assertFalse(cookie["secure"])
|
||||
self.assertFalse(cookie["domain"])
|
||||
self.assertEqual(cookies["/api"]["max-age"], "0")
|
||||
self.assertEqual(client.get("/").status_code, 200)
|
||||
self.assertEqual(client.get("/api/accounts").status_code, 200)
|
||||
token = client.cookies.get(COOKIE_NAME)
|
||||
self.assertEqual(len(token), 43)
|
||||
|
||||
Reference in New Issue
Block a user